diff --git a/Controllers/DygmaRaiseController/DygmaRaiseController.cpp b/Controllers/DygmaRaiseController/DygmaRaiseController.cpp index 2347d499..bbbe9fca 100644 --- a/Controllers/DygmaRaiseController/DygmaRaiseController.cpp +++ b/Controllers/DygmaRaiseController/DygmaRaiseController.cpp @@ -65,7 +65,7 @@ void DygmaRaiseController::SendDirect(std::vectorcolors, size_t led_nu /*-----------------------------------------------------*\ | Set up led theme packet | \*-----------------------------------------------------*/ - sprintf(serial_buf,"led.theme"); + snprintf(serial_buf, MAX_LEN, "led.theme"); int actual_length=9; /*-----------------------------------------------------*\ @@ -77,20 +77,20 @@ void DygmaRaiseController::SendDirect(std::vectorcolors, size_t led_nu int g = RGBGetGValue(colors[led_idx]); int b = RGBGetBValue(colors[led_idx]); - sprintf(serial_buf+actual_length," %d",r); + snprintf(serial_buf + actual_length, MAX_LEN - actual_length, " %d", r); actual_length += val_char_len(r) + 1; - sprintf(serial_buf+actual_length," %d",g); + snprintf(serial_buf + actual_length, MAX_LEN - actual_length, " %d", g); actual_length += val_char_len(g) + 1; - sprintf(serial_buf+actual_length," %d",b); + snprintf(serial_buf + actual_length, MAX_LEN - actual_length, " %d", b); actual_length += val_char_len(b) + 1; } /*-----------------------------------------------------*\ | Add the final newline | \*-----------------------------------------------------*/ - sprintf(serial_buf+actual_length,"\n"); + snprintf(serial_buf + actual_length, MAX_LEN - actual_length, "\n"); actual_length++; /*-----------------------------------------------------*\ diff --git a/Controllers/RobobloqLightStripController/RobobloqLightStripController.cpp b/Controllers/RobobloqLightStripController/RobobloqLightStripController.cpp index f9b1e366..e234304f 100644 --- a/Controllers/RobobloqLightStripController/RobobloqLightStripController.cpp +++ b/Controllers/RobobloqLightStripController/RobobloqLightStripController.cpp @@ -405,7 +405,7 @@ bool RobobloqLightStripController::RequestDeviceInfo() char uuid_buf[17]; for(int i = 0; i < 8; i++) { - sprintf(uuid_buf + (i * 2), "%02x", data[12 + i]); + snprintf(uuid_buf + (i * 2), sizeof(uuid_buf) - (i * 2), "%02x", data[12 + i]); } this->uuid = std::string(uuid_buf);